Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

94639 deselect bug fix #571

Merged
merged 4 commits into from
Mar 4, 2023
Merged

94639 deselect bug fix #571

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3b878b9
refs #94639 - adds check to prevent multiple delect all and select al…
jaybones90 Aug 8, 2022
e1e8932
Merge branch 'fae-3.0-rails-7-bump' into 94639-deselect-bug-fix
jaybones90 Aug 9, 2022
2716fbc
refs #94639 - adds passing test to verify bug fix
jaybones90 Jan 4, 2023
53dcf34
refs #94639 - adds semicolon
jaybones90 Jan 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions app/assets/javascripts/fae/form/inputs/_select.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,11 +92,17 @@ Fae.form.select = {
})
});

// Add actions to wraper
$deselect_all_action.insertAfter($chosen);
// prevent multiple deselect all actions from being added when nested forms are generated
if ($('.multiselect-action_wrap').length === 0) {
// Add actions to wraper
$deselect_all_action.insertAfter($chosen);
}

// Add special "Select All" option and notify Chosen of new option
addSelectAllOption($element)
// prevent multiple 'SELECT ALL' options from being added when nested forms are generated
if ($element[0].options[0].value != select_all_value) {
// Add special "Select All" option and notify Chosen of new option
addSelectAllOption($element)
jaybones90 marked this conversation as resolved.
Show resolved Hide resolved
}

// Mark label wrapper as having multiselect actions for styling
$label.addClass('has-multiselect-actions');
Expand Down