fix(logger): fix re-instantiation of winston loggers on method calls

weareopensource · Aug 26, 2017 · b6056fb · b6056fb
1 parent e7a8b9e
commit b6056fb
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/server/lib/services/express.js b/server/lib/services/express.js
@@ -5,7 +5,7 @@
  */
 var config = require('../config'),
   express = require('express'),
-  logger = require('./logger').log(),
+  log = require('./logger').log(),
   expressLogger = require('./logger').logExpress(),
   bodyParser = require('body-parser'),
   session = require('express-session'),

diff --git a/server/lib/services/logger.js b/server/lib/services/logger.js
@@ -6,10 +6,18 @@ const fs = require('fs');
 const winston = require('winston');
 const winstonExpress = require('express-winston');
 
+// maintain variables for singleton
+let logger;
+let loggerExpress;
+
 module.exports = class Logger {
   static log() {
+    if (logger) {
+      return logger;
+    }
+
     // Instantiating the default winston application logger with the Console transport
-    const logger = new winston.Logger({
+    logger = new winston.Logger({
       transports: [
         new winston.transports.Console({
           level: 'info',
@@ -72,7 +80,11 @@ module.exports = class Logger {
    * use with express logger
    */
   static logExpress() {
-    const logger = winstonExpress.logger({
+    if (loggerExpress) {
+      return loggerExpress;
+    }
+
+    loggerExpress = winstonExpress.logger({
       transports: [
         new winston.transports.Console({
           level: 'info',
@@ -85,6 +97,6 @@ module.exports = class Logger {
       colorize: true
     });
 
-    return logger;
+    return loggerExpress;
   }
 }