Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace prop css with emotion className #1

Merged
merged 3 commits into from
Dec 11, 2018
Merged

Replace prop css with emotion className #1

merged 3 commits into from
Dec 11, 2018

Conversation

dicearr
Copy link

@dicearr dicearr commented Dec 11, 2018

Motivation

Some components were using a prop css that was transpiled into className={css(...)} being css import {css} from 'emotion'. Therefore the nonce was not being added to these styles.

Changes

  • The emotion instance is now passed down to these components and the css prop has been replaced with the appropriate className.
  • The emotion instances are also cached in the Select constructor.

@dicearr dicearr self-assigned this Dec 11, 2018
@dicearr dicearr requested a review from Avaq December 11, 2018 08:19
@ghost
Copy link

ghost commented Dec 11, 2018

Danger run resulted in 3 warnings; to find out more, see the checks page.

Generated by 🚫 dangerJS

@Avaq Avaq merged commit b40c8c4 into avaq/nonce Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants