This repository was archived by the owner on Nov 23, 2021. It is now read-only.
Replace uglifyJs with terser #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
optimizations/index.js
Outdated
| @@ -1,4 +1,4 @@ | |||
| const UglifyJsPlugin = require('uglifyjs-webpack-plugin'); | |||
| const TerserPlugin = require('uglifyjs-webpack-plugin'); | |||
There was a problem hiding this comment.
Shouldn't this be require('terser-webpack-plugin')?
piotr-gawlowski
force-pushed
the
piotr/migrate-to-terser
branch
from
ad525e6 to
8a76599
Compare
indebanvdhamer
previously approved these changes
Mar 21, 2019
indebanvdhamer
approved these changes
Mar 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current version of react cannot be minified with UglifyJs. It's know issue for React team.
Terser is suggested by React team as a minifier for ES6 code.
Some sources:
rails/webpacker#1719
https://twitter.com/dan_abramov/status/1060245441084825600