Fix void elements that libxml2 does not know #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocean90
requested changes
Sep 23, 2024
inc/namespace.php
Outdated
Comment on lines
166
to
169
| '</embed>', | ||
| '</source>', | ||
| '</track>', | ||
| '</wbr>', |
There was a problem hiding this comment.
Let's extend the existing str_replace() call with these tags, you can update the comment as well.
ocean90
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libxml2 has some problems with void elements, it does not know. In these cases, it will add stray end tags that are not needed.
The missing elements are:
In most cases, this does not lead to visible problems because browsers will still be able to interpret the source code correctly. However, this still leads to invalid HTML and is not a desired side effect of our plugin.
The easiest, straight-forward approach would be just removing the stray end tags afterwards.
Reproduction
<source>to the content.