Detect nil attributes at runtime #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luontola
force-pushed
the
detect-runtime-attrs-vs-content
branch
from
7c11cdb
to
d9a8b7d
Compare
weavejester
requested changes
Dec 18, 2023
There was a problem hiding this comment.
Some very minor formatting suggestions. Could you also ensure the commit message uses plaintext rather than markdown formatting. So something like:
Fix formatting of nil attributes at runtime
Fix forms like (html [:br (identity nil)]) to produce "<br />" or "<br>"
rather than "<br></br>".
|
Thanks for the fix! And apologies for taking a little while to take a closer look. |
luontola
force-pushed
the
detect-runtime-attrs-vs-content
branch
from
d9a8b7d
to
181b936
Compare
|
Changes done. |
Fix forms like (html [:br (identity nil)]) to produce "<br />" or "<br>" rather than "<br></br>". The use case where this issue can happen is if the user has a function which returns either a map of attributes or nil.
luontola
force-pushed
the
detect-runtime-attrs-vs-content
branch
from
181b936
to
7196a47
Compare
|
@weavejester This too is ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change
(html [:br (identity nil)])used to produced"<br></br>". After this change it will produce"<br />".The use case where this can matter is if the user has a function which returns either a map of attributes or nil.