Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Label filtering #4

Merged
merged 4 commits into from
Jun 7, 2018
Merged

Label filtering #4

merged 4 commits into from
Jun 7, 2018

Conversation

awh
Copy link
Contributor

@awh awh commented Jun 4, 2018

Fixes #2.

awh
awh commented Jun 4, 2018
View reviewed changes
src/AlertDiff/Config.hs Outdated
@@ -21,6 +23,10 @@ stringList :: ReadM [String]
stringList = maybeReader f
where f s = Just $ splitOn "," s

stringSet :: ReadM (Set String)

This comment was marked as abuse.

Sign in to view

@awh
Copy link
Contributor Author

awh commented Jun 4, 2018 •
edited
Loading

With hindsight I would have done the AlertDiffer refactoring first, but the desirability of it only became apparent afterwards.

@awh awh requested a review from jml June 4, 2018 12:22
@awh awh force-pushed the label-filtering branch from 0917200 to 0a0c1b0 Compare June 5, 2018 12:55
jml
jml approved these changes Jun 5, 2018
View reviewed changes
Copy link

@jml jml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

@awh awh merged commit 4e245c0 into master Jun 7, 2018
@awh awh deleted the label-filtering branch June 7, 2018 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jml jml jml approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@awh @jml