We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server/server.go imports github.com/opentracing-contrib/go-grpc
This repo doesn't have a license (opentracing-contrib/go-grpc#3), so this makes weaveworks/common unusable for us.
go-grpc looks trivial, so if getting it licensed is somehow hard, it would probably not take very long to rewrite...
The text was updated successfully, but these errors were encountered:
Thanks for raising this. The code in that package was from https://github.com/grpc-ecosystem/grpc-opentracing, which does display a licence. I think we can assume this is an oversight in copying files rather than a real lack of licence.
I'll try again to make contact with its maintainers.
Sorry, something went wrong.
The upstream issue is now fixed. Can we update our dep?
add unit tests to increase coverage for encode and decode (weaveworks…
4724e92
…#160) Signed-off-by: tariqibrahim <tariq.ibrahim@microsoft.com>
No branches or pull requests
server/server.go imports github.com/opentracing-contrib/go-grpc
This repo doesn't have a license (opentracing-contrib/go-grpc#3), so this makes weaveworks/common unusable for us.
go-grpc looks trivial, so if getting it licensed is somehow hard, it would probably not take very long to rewrite...
The text was updated successfully, but these errors were encountered: