Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mappings to field config for Table #664

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

kumikoda
Copy link
Contributor

@kumikoda kumikoda commented Jul 12, 2024

What does this do?

This change enables you to configure value mappings for Table. Previously, the mappings argument provided would just get ignored.

Questions

I am not sure about backwards compatibility, but I am using Grafana v9.4.7 and it expects mappings in this location.

Copy link
Collaborator

@JamesGibo JamesGibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution

@JamesGibo JamesGibo merged commit 6b4ad2a into weaveworks:main Jul 16, 2024
5 checks passed
@abalfanzatomic
Copy link

this also leaves in the OLD incorrect/duplicated mappings entry in Table .. @JamesGibo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants