Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix kwargs for gitops formula #37

Merged
merged 1 commit into from
Dec 6, 2023
Merged

fix kwargs for gitops formula #37

merged 1 commit into from
Dec 6, 2023

Conversation

enekofb
Copy link
Contributor

@enekofb enekofb commented Dec 5, 2023

Closes #36

Applies suggestion from #36 (comment)

Cask 'gitops' is unreadable: wrong constant name #<Class:0x0000000127d5e3f0>
Warning: Treating /Users/enekofb/projects/github.com/weaveworks/homebrew-tap/Formula/gitops.rb as a formula.
==> Fetching gitops
==> Downloading https://github.com/weaveworks/weave-gitops/releases/download/v0.37.0/gitops-Darwin-arm64.tar.gz
Already downloaded: /Users/enekofb/Library/Caches/Homebrew/downloads/f49ca5e63c0ea4f1046fd40ca231f45d388b354026cdc60fdf251d2191f7c850--gitops-Darwin-arm64.tar.gz
==> Caveats
zsh completions have been installed to:
  /opt/homebrew/share/zsh/site-functions
==> Summary
🍺  /opt/homebrew/Cellar/gitops/0.37.0: 7 files, 65.3MB, built in 2 seconds
==> Running `brew cleanup gitops`...
Disable this behaviour by setting HOMEBREW_NO_INSTALL_CLEANUP.
Hide these hints with HOMEBREW_NO_ENV_HINTS (see `man brew`).

➜  homebrew-tap git:(issues/36) gitops version                                                                                                   Current Version: 0.37.0
GitCommit: 3f850ced58c9fe9d593807e299058e0e06c735eb
BuildTime: 2023-11-22T13:24:19Z
Branch: releases/v0.37.0

@enekofb enekofb marked this pull request as ready for review December 6, 2023 07:15
@enekofb enekofb changed the title using popen_read instead safe_popen_read does install fix kwargs for gitops formula Dec 6, 2023
@enekofb enekofb merged commit 5004b43 into master Dec 6, 2023
@enekofb enekofb deleted the issues/36 branch December 6, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gitops: TypeError: no implicit conversion of Hash into String
2 participants