Merge pull request #409 from chanwit/check_root_only_when_needed

skip root requirement for ignite version

cmd/ignite/cmd/root.go

@@ -19,6 +19,7 @@ import (
 	"github.com/weaveworks/ignite/pkg/providers"
 	"github.com/weaveworks/ignite/pkg/providers/ignite"
 	runtimeflag "github.com/weaveworks/ignite/pkg/runtime/flag"
+	"github.com/weaveworks/ignite/pkg/util"
 	versioncmd "github.com/weaveworks/ignite/pkg/version/cmd"
 )
 
@@ -37,6 +38,20 @@ func NewIgniteCommand(in io.Reader, out, err io.Writer) *cobra.Command {
 			// Set the desired logging level, now that the flags are parsed
 			logs.Logger.SetLevel(logLevel)
 
+			// TODO Some commands do not need to check root
+			// Currently it seems to be only ignite version that does not require root
+			if cmd.Name() == "version" && cmd.Parent().Name() == "ignite" {
+				return
+			}
+
+			// Ignite needs to run as root for now, see
+			// https://github.com/weaveworks/ignite/issues/46
+			// TODO: Remove this when ready
+			util.GenericCheckErr(util.TestRoot())
+
+			// Create the directories needed for running
+			util.GenericCheckErr(util.CreateDirectories())
+
 			// Populate the providers after flags have been parsed
 			if err := providers.Populate(ignite.Providers); err != nil {
 				log.Fatal(err)

cmd/ignite/ignite.go

@@ -17,14 +17,6 @@ func main() {
 
 // Run runs the main cobra command of this application
 func Run() error {
-	// Ignite needs to run as root for now, see
-	// https://github.com/weaveworks/ignite/issues/46
-	// TODO: Remove this when ready
-	util.GenericCheckErr(util.TestRoot())
-
-	// Create the directories needed for running
-	util.GenericCheckErr(util.CreateDirectories())
-
 	// Preload necessary providers
 	util.GenericCheckErr(providers.Populate(ignite.Preload))