Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Encode/decode meta.UID without "" #170

Closed
luxas opened this issue Jul 15, 2019 · 1 comment · Fixed by #178
Closed

Encode/decode meta.UID without "" #170

luxas opened this issue Jul 15, 2019 · 1 comment · Fixed by #178
Assignees
@twelho
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v0.4.2

Comments

@luxas
Copy link
Contributor

luxas commented Jul 15, 2019 •
edited
Loading

This bug/oversight was noticed during the TGIK session. Joe tried to set .metadata.uid=1234 (which should work), but the JSON parser errored that it must have " around it as it's decoded into a string.

We should fix this to allow decoding both with and without " around the value, but always encode without ", to be consistent with the name.
@luxas luxas added this to the v0.4.2 milestone Jul 15, 2019
@luxas luxas added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jul 15, 2019
@twelho twelho mentioned this issue Jul 15, 2019
Merged
@twelho
Copy link
Contributor

twelho commented Jul 15, 2019

Resolved in #178.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@twelho twelho

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v0.4.2
Development

Successfully merging a pull request may close this issue.

Allow unmarshaling unquoted Ignite UIDs from JSON weaveworks/ignite
2 participants
@luxas @twelho