Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Allow unmarshaling unquoted Ignite UIDs from JSON #178

Merged
merged 2 commits into from
Jul 15, 2019
Merged

Allow unmarshaling unquoted Ignite UIDs from JSON #178

merged 2 commits into from
Jul 15, 2019

Conversation

twelho
Copy link
Contributor

@twelho twelho commented Jul 15, 2019

This implements a custom unmarshaler, which supports decoding unquoted UID strings, so the user can enter "uid": 897302d44b0de795 in addition to "uid": "897302d44b0de795". Fixes #170.

cc @luxas

Copy link
Contributor

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@luxas luxas merged commit 8e7197d into master Jul 15, 2019
@luxas luxas deleted the uid-fix branch July 15, 2019 21:00
@twelho twelho added this to the v0.4.2 milestone Jul 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encode/decode meta.UID without ""
2 participants