Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Add .status.runtime.id to the VM API object #210

Closed
luxas opened this issue Jul 17, 2019 · 0 comments · Fixed by #294
Closed

Add .status.runtime.id to the VM API object #210

luxas opened this issue Jul 17, 2019 · 0 comments · Fixed by #294
Assignees
@twelho
Labels
api/v1alpha2 kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/design Categorizes issue or PR as related to the design of the project. priority/backlog Higher priority than priority/awaiting-more-evidence.
Milestone
v1alpha2

Comments

@luxas
Copy link
Contributor

luxas commented Jul 17, 2019

This will help us e.g. with CNI (#111), but in a couple of other places, too.

For example, instead of storing in .status.state if the VM is running, it could be done by actually looking up the containerID and telling whether it's running or not.
@luxas luxas added api/v1alpha2 kind/design Categorizes issue or PR as related to the design of the project. kind/enhancement Categorizes issue or PR as related to improving an existing feature. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Jul 17, 2019
@luxas luxas added this to the v1alpha2 milestone Jul 17, 2019
@luxas luxas mentioned this issue Jul 17, 2019
Merged
@twelho twelho mentioned this issue Aug 8, 2019
Merged
@luxas luxas closed this as completed in #294 Aug 8, 2019
@luxas luxas changed the title Add .status.containerID to the VM API object Add .status.runtime.id to the VM API object Aug 8, 2019
@luxas luxas added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API and removed kind/enhancement Categorizes issue or PR as related to improving an existing feature. labels Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@twelho twelho

Labels
api/v1alpha2 kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/design Categorizes issue or PR as related to the design of the project. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
v1alpha2
Development

Successfully merging a pull request may close this issue.

Add .status.runtime.id the VM container's ID twelho/ignite
2 participants
@luxas @twelho