-
Notifications
You must be signed in to change notification settings - Fork 228
CNI networking cleanup support, Docker client robustness improvements #111
Conversation
Thanks, will test in a moment |
Oops, didn't mean to close it. |
This got unblocked with #225. In other words, you can now run the cleanup func client-side in Ignite when removing a VM using CNI networking, as you can read the containerID from the annotation. |
# Conflicts: # api/ignite.md # pkg/metadata/vmmd/vm.go # pkg/operations/start.go
Also add a safety check for ensuring that cached Objects have their UID set.
This is to ensure no race conditions occur during e.g. `rm -f`, where a VM started with `-d` would still be in the process of being killed when remove is issued, leading to a crash.
I decided to go for implementing an |
@luxas is out of office, so as this is ready, going ahead and merging. |
This PR includes a bunch of fixes and improvements around container and cache handling:
-> you can now
rm -f
right afterstart -d
without Ignite crashing