makefile does not ensure output directories

[BenTheElder]

make tidy, will fail due to ./bin/cache/go/bin not existing. in general the make commands depend on directories that will not exist in a clean development environment and do not ensure that they exist.

[BenTheElder]

Addtionally, after writing a patch for this, it seems goimports must be installed on the host.

I would tentatively suggest something like creating a hack/tools go module to track development tools and install these to bin/ from the module instead of using whatever the host has installed.

[BenTheElder]

besides goimports, make tidy also depends on sfdp (graphviz?), I suppose we should just document this in devel? or possibly it could be run via a container?

[luxas]

Thanks! Fixed with #231. @twelho is now fixing the graphviz doc issue. Closing this :)

[BenTheElder]

Thanks!

…

On Tue, Jul 23, 2019 at 2:48 AM Lucas Käldström ***@***.***> wrote: Thanks! Fixed with #231 <#231>. @twelho <https://github.com/twelho> is now fixing the graphviz doc issue. Closing this :) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#230?email_source=notifications&email_token=AAHADK4LZFWCFPSU566OSTTQA3HVVA5CNFSM4IFP7SJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2SR6PA#issuecomment-514137916>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHADK5INNAPOVCLV64TJWDQA3HVVANCNFSM4IFP7SJQ> .