Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

ignite vm rm doesnt cleanup CNI #450

Closed
stealthybox opened this issue Sep 20, 2019 · 0 comments · Fixed by #515
Closed

ignite vm rm doesnt cleanup CNI #450

stealthybox opened this issue Sep 20, 2019 · 0 comments · Fixed by #515
Assignees
@stealthybox
Labels
area/networking Issues related to networking kind/bug Categorizes issue or PR as related to a bug.
Milestone
v0.7.0

Comments

@stealthybox
Copy link
Contributor

stealthybox commented Sep 20, 2019 •
edited
Loading

Follow-up to #442

@chanwit and I tested that the CNI-FORWARD rules per-vm are cleaned up on ignite vm stop.

However, I noticed this doesn't happen on ignite vm rm.
We could also check CNI state on vm removal and remove if necessary.
@stealthybox stealthybox added kind/bug Categorizes issue or PR as related to a bug. area/networking Issues related to networking labels Sep 20, 2019
@stealthybox stealthybox added this to the v0.6.1 milestone Sep 20, 2019
@stealthybox stealthybox self-assigned this Sep 20, 2019
@stealthybox stealthybox modified the milestones: v0.6.1, v0.7.0 Oct 2, 2019
michaelbeaumont added a commit to michaelbeaumont/ignite that referenced this issue Jan 30, 2020
@michaelbeaumont
Cleanup container networking on vm rm
1479676 
Fixes weaveworks#450
@michaelbeaumont michaelbeaumont mentioned this issue Jan 30, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@stealthybox stealthybox

Labels
area/networking Issues related to networking kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging a pull request may close this issue.

Cleanup container networking on vm rm michaelbeaumont/ignite
1 participant
@stealthybox