This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Object inspection support #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luxas
approved these changes
Jul 8, 2019
cmd/ignite/cmd/inspect.go
Outdated
| } | ||
|
|
||
| func addInspectFlags(fs *pflag.FlagSet, i *run.InspectFlags) { | ||
| fs.BoolVarP(&i.YAMLOutput, "yaml", "y", false, "Output the object in YAML format instead of JSON") |
There was a problem hiding this comment.
doesn't have to be done now, but eventually this should be done as --output=<type> => -o=yaml, -o=json instead for reusability and consistency.
cmd/ignite/cmd/inspect.go
Outdated
| "github.com/spf13/pflag" | ||
| "github.com/weaveworks/ignite/cmd/ignite/run" | ||
| "github.com/weaveworks/ignite/pkg/errutils" | ||
| "io" |
There was a problem hiding this comment.
should be in its own group up top
| "fmt" | ||
| "github.com/weaveworks/ignite/pkg/apis/ignite/scheme" | ||
| "github.com/weaveworks/ignite/pkg/client" | ||
| "github.com/weaveworks/ignite/pkg/filter" |
cmd/ignite/run/inspect.go
Outdated
| var kind meta.Kind | ||
| io := &inspectOptions{InspectFlags: i} | ||
|
|
||
| switch k { |
There was a problem hiding this comment.
strings.ToLower(k) to support ignite inspect Image foo if somebody would do it. no need to error in that case
There was a problem hiding this comment.
Yes, was not sure if it's needed as it could train the user "incorrect" usage. Implemented in c6622cf now.
Run `make tidy` as well which fixes the import ordering.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
ignite inspectcommand to retrieve the information/configuration of an Ignite object.