Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Add next-action for better developer-workflow #118

Merged
merged 1 commit into from
Jul 10, 2019

Conversation

alexellis
Copy link
Contributor

Adds a next-action of using Ignite after installing it.

Signed-off-by: Alex Ellis alexellis2@gmail.com

Adds a next-action of using Ignite after installing it.

Signed-off-by: Alex Ellis <alexellis2@gmail.com>
Copy link
Contributor

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
LGTM 👍

@luxas luxas merged commit 513616d into weaveworks:master Jul 10, 2019
@alexellis
Copy link
Contributor Author

Thanks for merging!

@luxas should I need to install KVM packages on Ubuntu for instance? If so, I would like to add a link to the requirements docs page i.e. See also: KVM on Ubuntu / KVM on CentOS / KVM on Fedora.

@alexellis alexellis deleted the alexellis/use-after-installation branch July 10, 2019 11:11
@luxas
Copy link
Contributor

luxas commented Jul 11, 2019

should I need to install KVM packages on Ubuntu for instance

No, just KVM support in the kernel/processor is enough.
Is the current merging in https://github.com/weaveworks/ignite/blob/master/docs/installation.md#system-requirements ok?

@alexellis
Copy link
Contributor Author

Looks good. I wonder if you can install kvm-ok without installing a load of other packages for libvirt?

# kvm-ok

Supported...

@luxas
Copy link
Contributor

luxas commented Jul 11, 2019

I just checked that yes, you can get it via a apt-get install cpu-checker, without libvirt deps. I'll create an issue

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants