Fix meta.ObjectMeta.Created to always be present and update itself automatically
#174
Conversation
twelho
changed the title
meta.ObjectMeta.Created to always be present and update itself automaticallymeta.ObjectMeta.Created to always be present and update itself automatically
pkg/apis/meta/v1alpha1/time.go
Outdated
| @@ -9,21 +10,67 @@ import ( | |||
| ) | |||
|
|
|||
| type Time struct { | |||
| metav1.Time | |||
| *metav1.Time | |||
There was a problem hiding this comment.
do we actually need this?
There is a metav1.Time.IsZero() method we could use instead.
There was a problem hiding this comment.
I didn't know about metav1.Time.IsZero(), will definitely use that instead of a pointer 👍
pkg/apis/meta/v1alpha1/time.go
Outdated
| ti = Timestamp() | ||
| } | ||
|
|
||
| b, err := ti.MarshalText() |
There was a problem hiding this comment.
this marshals the value without " on the sides. I don't think that's a good idea with YAML.
There was a problem hiding this comment.
instead, re-use metav1.Time's MarshalJSON func here
There was a problem hiding this comment.
Absolutely, fixed in 5b9bb3f.
pkg/apis/meta/v1alpha1/time.go
Outdated
| return json.Marshal(string(b)) | ||
| } | ||
|
|
||
| func (t *Time) UnmarshalJSON(b []byte) error { |
There was a problem hiding this comment.
In this function, only call the underlying metav1.Time Unmarshal func. If the input is no content, give metav1.Time.Unmarshal a byte array of null
There was a problem hiding this comment.
If the input is no content, the byte array is already empty (nil). We don't even need the custom unmarshaler to overload the underlying metav1.Time.UnmarshalJSON. Fixed in 5b9bb3f.
This changes
meta.ObjectMeta.Createdfrom being a pointer withomitemptyto a requiredTimestruct instance.Timenow embeds a pointer tometav1.Timeto tell if it's set and will set itself automatically upon marshaling if unset.If we don't need any
metav1.Timespecific functionality directly, we should probably move from embedding to have a private field, so anymetav1.Timemethods cannot be accidentally called with a nil receiver. What do you think @luxas ?