Support selecting the release when building Ignite images #193
Conversation
Currently release selection is supported for `amazonlinux`, `centos`, `ubuntu` and the `kubeadm` build based on `ubuntu`. To select a release, use the `RELEASE` env variable, e.g. `WHAT=ubuntu RELEASE=cosmic make`. The default release is `latest`.
|
By setting |
images/kubeadm/Dockerfile
Outdated
| FROM weaveworks/ignite-ubuntu:latest | ||
| ARG RELEASE | ||
|
|
||
| FROM weaveworks/ignite-ubuntu:${RELEASE} |
There was a problem hiding this comment.
for this, always lock it to 18.04; as that's vetted for k8s
images/Makefile
Outdated
| docker push ${DOCKER_USER}/ignite-${WHAT}:${VERSION} | ||
| docker tag ${DOCKER_USER}/ignite-${WHAT}:${VERSION} ${DOCKER_USER}/ignite-${WHAT}:latest | ||
| docker push ${DOCKER_USER}/ignite-${WHAT}:${TAG} | ||
| docker tag ${DOCKER_USER}/ignite-${WHAT}:${TAG} ${DOCKER_USER}/ignite-${WHAT}:latest | ||
| docker push ${DOCKER_USER}/ignite-${WHAT}:latest | ||
|
|
||
| build-all: |
There was a problem hiding this comment.
you need to set RELEASE for all of these to not lose information
There was a problem hiding this comment.
also, now we could build e.g. both k8s for 18.04, 16.04 and 19.04
reflect this change in the README; and update the ignite-ubuntu:latest strings to ignite-ubuntu:18.04
There was a problem hiding this comment.
you need to set RELEASE for all of these to not lose information
? Release should always be set, and is set automatically to latest.
There was a problem hiding this comment.
also, now we could build e.g. both k8s for 18.04, 16.04 and 19.04
reflect this change in the README; and update the ignite-ubuntu:latest strings to ignite-ubuntu:18.04
Isn't this what's done by the above change request? kubeadm now always uses 18.04.
There was a problem hiding this comment.
Yes, but I meant in these lines below; we run $(MAKE) build WHAT=foo. you need to add RELEASE in there to build the different combinations automatically (e.g. 18.04, 19.04, etc.).
The only thing I as an user should do to build everything is make push-all
There was a problem hiding this comment.
OK gotcha. Now done, bb35f84 builds 16.04, 18.04 and 19.04 of ubuntu.
images/Makefile
Outdated
| $(MAKE) ${OP} WHAT=alpine | ||
| $(MAKE) ${OP} WHAT=ubuntu RELEASE=16.04 IS_LATEST=true | ||
| $(MAKE) ${OP} WHAT=ubuntu RELEASE=18.04 IS_LATEST=true | ||
| $(MAKE) ${OP} WHAT=ubuntu RELEASE=19.04 IS_LATEST=true |
There was a problem hiding this comment.
there can only be one latest tag. remove IS_LATEST from 19.04 and 16.04
There was a problem hiding this comment.
Whoops, copy-pasted them a bit too quickly 😄. Done in
91e375e.
images/Makefile
Outdated
| $(MAKE) ${OP} WHAT=amazon-kernel | ||
| $(MAKE) ${OP} WHAT=amazonlinux RELEASE=2 IS_LATEST=true | ||
| $(MAKE) ${OP} WHAT=alpine | ||
| $(MAKE) ${OP} WHAT=ubuntu RELEASE=16.04 IS_LATEST=true |
There was a problem hiding this comment.
remove IS_LATEST here, 18.04 is the only one with that
There was a problem hiding this comment.
18.04 is now the latest of ignite-ubuntu.
Currently release selection is supported for
amazonlinux,centos,ubuntuand thekubeadmbuild based onubuntu. To select a release,use the
RELEASEenv variable, e.g.WHAT=ubuntu RELEASE=cosmic make.The default release is
latest. Fixes #116.