This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
pkg/apis/ignite
, where the external types should bev1alpha1
and internalThis allows us to roll out more supported external types, e.g. v1alpha2, without disrupting v1alpha1 support. Also, it will allow us to streamline validation, helper method registration, and defaulting.
For more information about how this works, see my talk from KubeCon Shanghai, along with the minimal sample-config implementation:
Fixes: #183