Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Documentation updates and clarifications for the New Storage implementation #242

Merged
merged 8 commits into from
Jul 29, 2019

Conversation

twelho
Copy link
Contributor

@twelho twelho commented Jul 29, 2019

Extends @luxas's reviews in #234 to provide additional fixes and documentation clarifications. See the aforementioned PR for details.

@twelho twelho added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. do-not-merge/wip The PR is still work in progress labels Jul 29, 2019
@twelho twelho added this to the v0.5.0 milestone Jul 29, 2019
Copy link
Contributor

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@twelho twelho requested a review from luxas July 29, 2019 16:37
@twelho twelho removed the do-not-merge/wip The PR is still work in progress label Jul 29, 2019
@twelho
Copy link
Contributor Author

twelho commented Jul 29, 2019

Now it's ready, all comments of #234 are now addressed and the code is rebased on top of master.

@twelho
Copy link
Contributor Author

twelho commented Jul 29, 2019

Removed the graph update.

@luxas luxas merged commit 6a2257d into weaveworks:master Jul 29, 2019
@twelho twelho deleted the syncstorage branch July 29, 2019 16:42
@luxas luxas removed the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants