Extract watcher, batcher and monitor into pkg/util #245
Conversation
luxas
added
kind/refactor
| ) | ||
|
|
||
| // Update bundles an Event with an | ||
| // APIType for Storage retrieval. | ||
| type Update struct { | ||
| Event Event | ||
| Event watcher.Event |
There was a problem hiding this comment.
Event though watcher uses the Events the most, they are not watcher specific, the same events are used to detect changes for Objects in WatchStorage and SyncStorage. Should we move Event to watcher or keep it in update, to be generic?
There was a problem hiding this comment.
I think it's better to keep the types fairly closely to where they are used. I did not understand the purpose of the types when seeing them grouped in the update package. I think they are a good fit in this package, at least until something more significant changes in the codebase.
There was a problem hiding this comment.
As it seems to work for WatchStorage and SyncStorage in terms of dependencies, LGTM 👍. After a rebase feel free to merge.
|
Rebased; merging now |
luxas
added
the
kind/enhancement
This makes them reusable in a generic manner, and not tied to
pkg/storage