This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Add new binary: ignited
#264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luxas
added
kind/refactor
twelho
approved these changes
Aug 1, 2019
cmd/ignited/cmd/root.go
Outdated
|
|
||
| // AddQuietFlag adds the quiet flag to a flagset | ||
| func AddQuietFlag(fs *pflag.FlagSet) { | ||
| fs.BoolVarP(&logs.Quiet, "quiet", "q", logs.Quiet, "The quiet mode allows for machine-parsable output, by printing only IDs") |
cmd/ignite/cmd/root.go
Outdated
| ) | ||
|
|
||
| var logLevel = logrus.InfoLevel | ||
|
|
||
| // NewIgniteCommand returns the root command for ignite | ||
| func NewIgniteCommand(in io.Reader, out, err io.Writer) *cobra.Command { | ||
| // Set the default logging level | ||
| logs.Logger.SetLevel(logLevel) |
There was a problem hiding this comment.
I assume the flag based log level is set somewhere now that PersistentPreRun is removed?
|
Fixed the review comments, merging... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #254
Related to #33 and #24