Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Add vm.status.startTime to track the VM's uptime externally #296

Merged
merged 2 commits into from
Aug 8, 2019

Conversation

twelho
Copy link
Contributor

@twelho twelho commented Aug 8, 2019

The time isn't written to the file yet, for the same reason as #294. It will be visible in ignite ps when enabled. This PR is part of the API changes for v0.5.0.

cc @luxas

Fixes: #297

@twelho twelho added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/design Categorizes issue or PR as related to the design of the project. labels Aug 8, 2019
@twelho twelho added this to the v0.5.0 milestone Aug 8, 2019
Copy link
Contributor

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

@luxas luxas merged commit 28f3a40 into weaveworks:master Aug 8, 2019
@twelho twelho deleted the start-time branch August 29, 2020 09:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/design Categorizes issue or PR as related to the design of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add .status.startTime to the VM to compute uptime
2 participants