[WIP] feat: expose mmds #304
Conversation
|
|
||
| if enableMmds { | ||
| //cfg.KernelArgs = fmt.Sprintf("%s -device vhost-vsock-pci,id=vhost-vsock-pci0,guest-cid=3") |
| @@ -22,12 +22,15 @@ import ( | |||
| // ExecuteFirecracker executes the firecracker process using the Go SDK | |||
| func ExecuteFirecracker(vm *api.VM, dhcpIfaces []DHCPInterface) error { | |||
| drivePath := vm.SnapshotDev() | |||
| mmdsData := os.Getenv("FC_META") | |||
There was a problem hiding this comment.
cleanup; take from vm spec
|
Hm! I’ve already learned a few things, notably that CID should be unique per VM. Not sure how to track that though, maybe some sort of global cache? Or check existence first somehow? |
|
Thanks for this contribution @alexeldeib ✨💯🎉! |
|
(notes to self as I work through this) I think I should also use kernel args TODO
|
luxas
added
the
kind/feature
|
(had some issues with my dev environment, will work on finishing this up soon) |
| @@ -70,6 +70,7 @@ func addCreateFlags(fs *pflag.FlagSet, cf *run.CreateFlags) { | |||
| // Register flags for simple types (int, string, etc.) | |||
| fs.Uint64Var(&cf.VM.Spec.CPUs, "cpus", cf.VM.Spec.CPUs, "VM vCPU count, 1 or even numbers between 1 and 32") | |||
| fs.StringVar(&cf.VM.Spec.Kernel.CmdLine, "kernel-args", cf.VM.Spec.Kernel.CmdLine, "Set the command line for the kernel") | |||
| fs.StringVar(&cf.VM.Spec.Metadata, "metadata", cf.VM.Spec.Metadata, "Enable MMDS and use this JSON value for creation metadata") | |||
There was a problem hiding this comment.
We'd also want to point this to a file; and use that content instead of requiring the JSON to be inline.
| @@ -185,7 +185,8 @@ type VMSpec struct { | |||
| // Specifying a path in SSH.Generate means "use this public key" | |||
| // If SSH.PublicKey is set, this struct will marshal as a string using that path | |||
| // If SSH.Generate is set, this struct will marshal as a bool => true | |||
| SSH *SSH `json:"ssh,omitempty"` | |||
| SSH *SSH `json:"ssh,omitempty"` | |||
| Metadata string `json:"metadata,omitempty"` | |||
There was a problem hiding this comment.
would []byte be a better format?
also add this field to v1alpha2 please
| c, err := dc.client.ContainerCreate(context.Background(), &container.Config{ | ||
| Hostname: config.Hostname, | ||
| Tty: true, // --tty | ||
| OpenStdin: true, // --interactive | ||
| Cmd: config.Cmd, | ||
| Env: config.Env, |
| @@ -74,6 +75,8 @@ func StartVM(vm *api.VM, debug bool) error { | |||
| runtime.BindBoth("/dev/net/tun"), // Needed for creating TAP adapters | |||
| runtime.BindBoth("/dev/kvm"), // Pass through virtualization support | |||
| runtime.BindBoth(vm.SnapshotDev()), // The block device to boot from | |||
| runtime.BindBoth("/dev/vhost-vsock"), | |||
There was a problem hiding this comment.
only if metadata is present?
|
Firecracker v0.18.0 released with "real" vsock support :) https://github.com/firecracker-microvm/firecracker/blob/master/docs/vsock.md |
|
🙁 sorry for leaving this dangling. I haven't had the time to properly invest (or i've been diverting it elsehwere, unfortunately). I'm going to close this. If I am able to brush up on vsock and implement the real thing, I'll open it in a new PR. Still appreciate the project and enjoy playing with it 🙂 |
ref #77
I took an initial stab at exposing MMDS. I'm not super familiar with vsock -- does this approach make sense? is a constant okay for CID/path? I can pull those into the constants file.
One issue with MMDS is it requires a firecracker binary compiled with vsock support. This is fairly easy on a local machine but I am still struggling to build it in the docker image. So definitely don't merge this 😉
Additionally, since the metadata must be injected to firecracker VM from inside the container, I've opted to pass the metadata as Environment variable at Boot time (should hook in properly to start as well as run).