This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Fix ignite-spawn's formatting when performing cleanup on VM metadata #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twelho
added
kind/cleanup
|
@luxas is out of office, so going ahead and merging now that CI is green. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignite-spawndirectly writes the output ofStrategicMergePatchto the metadata file, resulting in the formatting/indentation being lost (it's all just one unorganized line). With these changes theStrategicMergePatchoutput is re-encoded via the serializer to preserve theruntime.Objectstructure and indentation on write.cc @luxas