Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Simplify the CNI code by vendoring github.com/containerd/go-cni #349

Merged
merged 3 commits into from
Aug 19, 2019

Conversation

luxas
Copy link
Contributor

@luxas luxas commented Aug 19, 2019

This allows us to remove most of our CNI-specific code, yay 😄

This makes it easier to move to containerd, too: #337

@luxas luxas added area/dependency Issues or PRs related to dependency changes kind/refactor Categorizes issue or PR as related to refactoring code. kind/enhancement Categorizes issue or PR as related to improving an existing feature. labels Aug 19, 2019
@luxas luxas added this to the v0.6.0 milestone Aug 19, 2019
@luxas luxas requested a review from twelho as a code owner August 19, 2019 11:42
Copy link
Contributor

@twelho twelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make tidy seems to be failing for the CI, otherwise LGTM 👍

@luxas
Copy link
Contributor Author

luxas commented Aug 19, 2019

CI is now green, merging...

@luxas luxas merged commit 083c2c1 into weaveworks:master Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/dependency Issues or PRs related to dependency changes kind/enhancement Categorizes issue or PR as related to improving an existing feature. kind/refactor Categorizes issue or PR as related to refactoring code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants