This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
preflight before start operation #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luxas
reviewed
Aug 26, 2019
pkg/preflight/checks.go
Outdated
| return "ExistingFile" | ||
| } | ||
|
|
||
| type AvailablePathChecker struct { |
pkg/preflight/checks.go
Outdated
| vmDir := filepath.Join(constants.VM_DIR, vm.GetUID().String()) | ||
| kernelDir := filepath.Join(constants.KERNEL_DIR, kernelUID.String()) | ||
| log.Println(vm.GetUID().String()) | ||
| checks = append(checks, ExistingFileChecker{filePath: path.Join(vmDir, constants.METADATA)}) |
There was a problem hiding this comment.
No need to check for the metadata and kernel files, they are gonna be created on the fly.
pkg/preflight/checks.go
Outdated
| } | ||
| vmDir := filepath.Join(constants.VM_DIR, vm.GetUID().String()) | ||
| kernelDir := filepath.Join(constants.KERNEL_DIR, kernelUID.String()) | ||
| log.Println(vm.GetUID().String()) |
pkg/preflight/checks.go
Outdated
| for _, port := range vm.Spec.Network.Ports { | ||
| checks = append(checks, PortOpenChecker{port: port.HostPort}) | ||
| } | ||
| return runChecks(checks, ignoredPreflightErrors) |
There was a problem hiding this comment.
other things that could be added:
- make sure that the docker/containerd socket exists?
- this could be done by extending
runtime.Interfacewith aPreflightChecker() preflight.Checkermethod. when invoked, it would make sure docker / containerd sockets exist - here in this method you'd do
checks = append(checks, providers.Runtime.PreflightChecker())
- this could be done by extending
- make sure all the binaries listed in https://ignite.readthedocs.io/en/stable/dependencies.html are present in PATH
twelho
reviewed
Aug 30, 2019
pkg/preflight/checkers/checks.go
Outdated
| "strings" | ||
|
|
||
| "k8s.io/apimachinery/pkg/util/sets" | ||
|
|
| checks = append(checks, ExistingFileChecker{filePath: "/dev/mapper/control"}) | ||
| checks = append(checks, ExistingFileChecker{filePath: "/dev/net/tun"}) | ||
| checks = append(checks, ExistingFileChecker{filePath: "/dev/kvm"}) | ||
| checks = append(checks, providers.Runtime.PreflightChecker()) |
There was a problem hiding this comment.
This could be an inline constructor instead of 4 allocations
The start operation preflight checks files exists and ports are available
…+ alloc properly the checkers array The package was not using the interface from the preflight package. We use it now and we deleted the interface in the checkers package. Multiple re-allocation was occuring when appending checkers to the array. Now, allocation is done at the beginning by calculating the total number of checkers we will store in the array.
najeal
force-pushed
the
najeal/184-preflight
branch
from
04618ef
to
0256496
Compare
|
Done. |
|
This preflight would be a life saver, thank you @najeal !! It seems that we have some changes since last time, like
Small things left to be addressed. /cc @stealthybox |
luxas
approved these changes
Sep 9, 2019
There was a problem hiding this comment.
Talked to @chanwit and @stealthybox, this will be very valuable in v0.6.1.
Merging to unblock @chanwit.
LGTM, thanks @najeal 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds preflight checks before start operation.
Fixes #184