Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Update Makefile for containerd with overridable commands #417

Merged
merged 2 commits into from
Sep 11, 2019

Conversation

stealthybox
Copy link
Contributor

@stealthybox stealthybox commented Sep 11, 2019

This loads the dev image into containerd when you run either:

make bin/$(go env GOARCH)/Dockerfile

or

make build-all

Changes:

  • Load ignite:dev image into containerd using root via ctr in a docker container
  • Allow user to override docker command: make DOCKER="sudo docker" <target>

@chanwit

@stealthybox stealthybox force-pushed the make-docker-ctr branch 2 times, most recently from 3dc94fa to 3c75014 Compare September 11, 2019 06:28
@stealthybox stealthybox added kind/bug Categorizes issue or PR as related to a bug. kind/refactor Categorizes issue or PR as related to refactoring code. labels Sep 11, 2019
@chanwit chanwit removed the request for review from twelho September 11, 2019 08:57
@chanwit chanwit added this to the v0.6.1 milestone Sep 11, 2019
@chanwit
Copy link
Member

chanwit commented Sep 11, 2019

worked for me nicely. Thank you @stealthybox !

@chanwit chanwit merged commit 90f443a into weaveworks:master Sep 11, 2019
@stealthybox stealthybox deleted the make-docker-ctr branch September 11, 2019 10:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/refactor Categorizes issue or PR as related to refactoring code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants