Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Store e2e command output /w errors + remove variable sleep #425

Merged
merged 1 commit into from
Sep 14, 2019

Conversation

stealthybox
Copy link
Contributor

This makes the test output much more readable. Errors are nested with their command args.
It also allows you to read parallel output.
I haven't enabled parallel, because vm run appears to have a bug using dmsetup in parallel.

Successful commands no longer output to stdout, but we could add a gate for this if desired.

I removed the variable sleep because it appears to have less impact on the docker-bridge behavior in #423 than I previously observed.

@chanwit chanwit self-assigned this Sep 14, 2019
@chanwit chanwit added this to the v0.6.1 milestone Sep 14, 2019
@chanwit chanwit added the area/testing Issues related to improving testing label Sep 14, 2019
@chanwit chanwit requested review from chanwit and removed request for twelho September 14, 2019 11:37
@chanwit
Copy link
Member

chanwit commented Sep 14, 2019

LGTM

@chanwit chanwit merged commit e8a2996 into weaveworks:master Sep 14, 2019
@stealthybox stealthybox deleted the improve_e2e branch September 16, 2019 03:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/testing Issues related to improving testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants