Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Make getIPChains more precise and less failure-prone #426

Merged
merged 1 commit into from
Sep 14, 2019

Conversation

stealthybox
Copy link
Contributor

@stealthybox stealthybox commented Sep 13, 2019

move fmt.Sprintf out of loop
access stat.Options through rawStat[9] with hard-coded index
remove break in the event there are multiple rules per containerID
only parse for IPNet when we are working with the proper ignite CNI rules
^ avoids coreos/go-iptables#70

Fixes #393

@stealthybox stealthybox removed the request for review from twelho September 13, 2019 00:11
@stealthybox stealthybox added area/dependency Issues or PRs related to dependency changes area/networking Issues related to networking kind/bug Categorizes issue or PR as related to a bug. labels Sep 13, 2019
move fmt.Sprintf out of loop
access stat.Options through rawStat[9] with hard-coded index
remove break in the event there are multiple rules per containerID
only parse for IPNet when we are working with the proper ignite CNI rules
  ^ avoids coreos/go-iptables#70
@chanwit chanwit self-requested a review September 13, 2019 06:44
@chanwit chanwit added this to the v0.6.1 milestone Sep 13, 2019
@chanwit chanwit merged commit 2bde2cb into weaveworks:master Sep 14, 2019
@chanwit
Copy link
Member

chanwit commented Sep 14, 2019

LGTM

@stealthybox stealthybox deleted the workaround-iptables branch September 16, 2019 03:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/dependency Issues or PRs related to dependency changes area/networking Issues related to networking kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting a CNI removal error when doing ignite vm stop
2 participants