-
Notifications
You must be signed in to change notification settings - Fork 228
Conversation
Related #345 |
Also see #513 |
This is ready to merge, ping @stealthybox |
Hi, I gave this a try on a gentoo64-on-rpi-64bit machine and it worked well with docker and docker-bridge 🙂 With containerd and cni, I got the following error:
Need to debug and find out why it failed. Used docker and docker-bridge and was able to create multiple VMs:
I was able to ssh into the VMs and use them.
Built all the images (kernel, OS and sandbox) and ignite for arm64. This is great. Thanks! |
$(MAKE) ${OP} WHAT=ubuntu RELEASE=18.04 IS_LATEST=true IS_MANIFEST_LIST=1 GOARCH=arm64 | ||
$(MAKE) ${OP} WHAT=ubuntu RELEASE=18.04 IS_LATEST=true IS_MANIFEST_LIST=1 GOARCH=amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack -- only adding am arm64/aarch64 userspace image for Ubuntu 18.04 starting out
# ARCH here is KERNEL_ARCH in the Makefile. It needs to be hardcoded to ARCH for Kconfig to understand | ||
ARG ARCH | ||
ARG GOARCH | ||
ARG ARCH_MAKE_PARAMS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comment
#!/bin/bash | ||
|
||
if [[ $# == 0 ]]; then | ||
echo "Usage: $0 [manifest-list] [arch0...n]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice move breaking this non-trivial manifest list logic into something that's generally useful for both the userspace and kernel images. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty clean build logic for all of the cross-compilation and conditional branching on ARCH these changes enabled.
Thanks for following through and supporting this change-set, @luxas.
Thanks @darkowlzz for building the artifacts and hand-testing them with a custom built OS on your RaspberryPi.
That's not trivial work at all!
We'll have to see if we can replicate the CNI issue you saw. (perhaps your CNI binaries or other downstream dependencies were the wrong arch and it was poor error reporting?)
@luxas did not report CNI issues in his experiments.
@darkowlzz @stealthybox This is why I upgraded CNI to v0.8.5: #561. containernetworking/plugins#434 |
@stealthybox @chanwit Builds on top of #506, makes us have a prebuilt kernel and Ubuntu for ARM64