This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Template formatted output for ps & inspect #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkowlzz
force-pushed
the
formatted-output-ps-inspect
branch
3 times, most recently
from
0ab526b
to
1eff553
Compare
darkowlzz
force-pushed
the
formatted-output-ps-inspect
branch
from
1eff553
to
918e2fb
Compare
|
Updated the commits to replace separate flags for updating the test golden files with a single |
|
The template format works great, but the golden-file tests are flaky because the output order is not sorted and stable. Running with Perhaps we should consider sorting by name or ID before outputting the table. Also, you may find it helpful to change the test runner to output strings: t.Errorf("expected output to be:\n%v\ngot output:\n%v", string(wantOutput), string(buf.Bytes())) |
This adds a new flag to `ignite ps` command `--template` to render the ps output based on passed Go template. Adds test for Ps().
This adds a new flag to `ignite inspect` command `--template` to render the inspect output based on passed Go template. Adds test for Inspect().
Use a slice for the list of existing VMs to retain the order of the VMs created in the test. Update the test runner to print strings of the compared outputs, instead of bytes.
darkowlzz
force-pushed
the
formatted-output-ps-inspect
branch
from
918e2fb
to
4c67348
Compare
|
Thanks for catching the issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new flag
--template(-t) for Go template formatted output ininspectandpssubcommands.Since
pscommand already has a-fflag for--filter, this uses-tfor template formatted output.Adds golden files based tests for Inspect() and Ps() to verify the results.