Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Use the new libgitops GitDirectory implementation #615

Merged
merged 2 commits into from
Jun 9, 2020
Merged

Use the new libgitops GitDirectory implementation #615

merged 2 commits into from
Jun 9, 2020

Conversation

luxas
Copy link
Contributor

@luxas luxas commented Jun 9, 2020

@luxas luxas requested a review from stealthybox as a code owner June 9, 2020 11:55
twelho
twelho approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@twelho twelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it's good to get the cleanup wired up as well but that can happen in a follow-up PR. This one already pulls in enough deps 😅

pkg/gitops/gitops.go
if err != nil {
return err
}
// TODO: Run gitDir.Cleanup() on SIGINT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related implementation:

ignite/pkg/container/firecracker.go

Line 147 in d988680

// Install custom signal handlers:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I know, and we have one already in ignited, but in an other place. For laters

@luxas luxas merged commit c89b151 into weaveworks:master Jun 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@twelho twelho twelho approved these changes

@stealthybox stealthybox Awaiting requested review from stealthybox

Assignees

@twelho twelho

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luxas @twelho