This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Add Golangci-lint and fix errors #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkowlzz
added
the
kind/cleanup
darkowlzz
commented
Jul 12, 2020
darkowlzz
commented
Jul 12, 2020
darkowlzz
commented
Jul 12, 2020
Golangci-lint run fails due to errors in pkg/dm even if pkg/dm is added in skip-dirs. The skip is a lint skip, the go code must be valid.
Due to the size of the repo, lint run fails after a minute, the default timeout. Pass --timeout argument to increase the run timeout.
luxas
approved these changes
Jul 20, 2020
twelho
approved these changes
Jul 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds golangci-lint github action.