Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Exec blkid to getUUID() instead of relying on udevd symlinks #652

Merged
merged 1 commit into from
Aug 10, 2020

Conversation

stealthybox
Copy link
Contributor

This allows ignite to use volumes when udevd is not running such as within WSL2 or a docker container.
getUUID() is called as part of writing fstab for the VM fs.

blkid is included in utils-linux on ubuntu systems and has its own package on alpine linux.
It should be installed by default in most environments, but we may need to update our dependencies list to call out this new binary-exec dependency.

blkid uses libblkid1 internally.
I could not find a go library that did not exec the program.

@stealthybox stealthybox added kind/enhancement Categorizes issue or PR as related to improving an existing feature. area/dependency Issues or PRs related to dependency changes area/runtime Issues related to container runtimes labels Aug 5, 2020
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stealthybox stealthybox merged commit 732f9bf into weaveworks:master Aug 10, 2020
@stealthybox stealthybox deleted the getuuid-no-udev branch August 10, 2020 16:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/dependency Issues or PRs related to dependency changes area/runtime Issues related to container runtimes kind/enhancement Categorizes issue or PR as related to improving an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants