Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Configuring proper gateway for ignite-spawn DHCP #665

Merged
merged 2 commits into from
Aug 24, 2020

Conversation

stealthybox
Copy link
Contributor

Fixes #664

Changes:

  • 0b4ff4d Configuring proper gateway for ignite-spawn DHCP
  • 07f93ab Remove string parsing for IP address conversion

@lukemarsden
Copy link

Nice one, lgtm!

Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@stealthybox
Copy link
Contributor Author

There are limitations that make this impractical to currently write tests for

Basically the CNI bridge is responsible for handing out IP's
We could potentially create a test env, where the CNI bridge is groomed to already pass out larger IP's or something in the future.

Ignite has no current abililty to pre-define what that IP could be, but if that changes in the future, we would certainly want to test for this.

In general, the ignite-spawn sandbox process is under-tested at an individual level, but it is covered generally in the e2e tests.

Thanks for the reviews!
Super pleased to merge this fix

@stealthybox stealthybox merged commit 9b03c5c into weaveworks:master Aug 24, 2020
@stealthybox stealthybox deleted the gateway-pivot branch August 24, 2020 15:43
@lukemarsden
Copy link

lukemarsden commented Aug 24, 2020

@stealthybox thanks so much! Any chance you could cut a release so we can try it out in our environment please?

@lukemarsden
Copy link

@stealthybox @luxas sorry to bother you, but if you could release a version of ignite with this fix it, would be greatly appreciated! As we increase our usage of Ignite, we keep running into this more and more frequently. Thanks so much!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gateway set incorrectly in VMs after 256 VMs created
3 participants