Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Update ignite help, image and kernel to no longer require root #676

Merged
merged 1 commit into from
Sep 3, 2020
Merged

Update ignite help, image and kernel to no longer require root #676

merged 1 commit into from
Sep 3, 2020

Conversation

Khalian
Copy link
Contributor

@Khalian Khalian commented Aug 27, 2020

Help should not need root.

@Khalian
Copy link
Contributor Author

Khalian commented Aug 27, 2020

Testing

make
make install

Then ran

ignite help
ignite image ps
ignite kernel ps

And all of them passed without a hitch.

@Khalian Khalian changed the title Update ignite help to no longer require root Update ignite help, image and kernel to no longer require root Aug 27, 2020
cmd/ignite/cmd/root.go Outdated Show resolved Hide resolved
@darkowlzz
Copy link
Contributor

Thanks for working on this. I went through all the commands to see which of them don't require root.
ps, inspect and completion don't require root.
inspect for vm, image and kernel, all work without root as they are just reading the metadata file.
Most of the other commands require permission to access some files and interact with the runtime.

@darkowlzz darkowlzz added the kind/enhancement Categorizes issue or PR as related to improving an existing feature. label Aug 31, 2020
@stealthybox
Copy link
Contributor

This patch already looks good but +1 on using the switch and adding the other commands if you have a moment.

Thanks for fixing this!

cmd/ignite/cmd/root.go Outdated Show resolved Hide resolved
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested it and works well.
Almost ready, just need to include ps as well.

@Khalian
Copy link
Contributor Author

Khalian commented Sep 2, 2020

Manually tested it and works well.
Almost ready, just need to include ps as well.

Done. I made the change.

Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot for the patch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement Categorizes issue or PR as related to improving an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants