Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Remove runtime info from version #677

Merged
merged 1 commit into from
Sep 9, 2020
Merged

Remove runtime info from version #677

merged 1 commit into from
Sep 9, 2020

Conversation

darkowlzz
Copy link
Contributor

Runtime will no longer be a global flag but a VM and image specific
subcommand flag after #669

$ sudo ignite version
Ignite version: version.Info{Major:"", Minor:"", GitVersion:"", GitCommit:"", GitTreeState:"", BuildDate:"2020-08-30T18:31:52Z", GoVersion:"go1.14.2", Compiler:"gc", Platform:"linux/amd64", SandboxImage:version.Image{Name:"weaveworks/ignite", Tag:"dev", Delimeter:":"}, KernelImage:version.Image{Name:"weaveworks/ignite-kernel", Tag:"4.19.125", Delimeter:":"}}
Firecracker version: v0.21.1

@darkowlzz
Remove runtime info from version
61fdefb 
Runtime will no longer be a global flag but a VM and image specific
subcommand flag.
@darkowlzz darkowlzz requested a review from twelho as a code owner August 30, 2020 18:44
@stealthybox stealthybox merged commit 9560a71 into weaveworks:master Sep 9, 2020
@darkowlzz darkowlzz deleted the version-runtime branch September 9, 2020 16:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@twelho twelho Awaiting requested review from twelho

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darkowlzz @stealthybox