This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Export command option types #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignite command functions accept unexported types like `startOptions`, `createOptions`, etc. This makes the cmd/ignite/run package unusable for projects that import ignite. IDEs warn about unexported return type for functions like `NewStartOptions()`, `NewCreateOptions()`, etc. This change makes those option types public.
|
I'm fine with this, especially since our implementations are currently too conflated with the cobra command setup code. We don't promise these types will be stable, but folks can pin to our releases, and exposing them allows others to build cool things. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignite command functions accept unexported types like
startOptions,createOptions, etc. This makes the cmd/ignite/run package unusable forprojects that import ignite.
IDEs warn about unexported return type for functions like
NewStartOptions(),NewCreateOptions(), etc.This change makes those option types public.