This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Fix starting VM with non-default providers #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At VM start, check if the providers flags are set before updating the VM status with the providers info. This ensures that the providers of a VM are changed only when explicitly set in the start command. Add e2e test to verify the fix.
|
ty for bug fix friend 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At VM start, check if the providers flags are set before updating the
VM status with the providers info. This ensures that the providers of a
VM are changed only when explicitly set in the start command.
Add e2e test to verify the fix.
Follow-up to #669