This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Upgrade to Firecracker v0.22.0 #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stealthybox
force-pushed
the
fc-0-22
branch
from
840d72c
to
03c0bb9
Compare
Bump firecracker-go-sdk -- thanks to the upstream team for the release The firecracker rust API's have changed the fields for `log_fifo` -> `log_path` and `metrics_fifo`->`metrics_path`. Metrics have been moved to their own API call. This change is breaking on the firecracker side, but the firecracker-go-sdk Config has been kept backwards compatible. This means that ignite users will have no action item when upgrading ignite. The ignite-sandbox binary inside the sandbox image just needs to match the version of firecracker to avoid any API mismatch.
stealthybox
added
the
area/dependency
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump firecracker-go-sdk to a171aa18f6749f54178aa46ecfdf63eeb211d200
The firecracker rust API's have changed the fields for
log_fifo->log_pathand
metrics_fifo->metrics_path.Metrics have been moved to their own API call.
This change is breaking on the firecracker side, but the firecracker-go-sdk
Config has been kept backwards compatible.
We can either merge this now or work with the Firecracker team to get a new SDK release.