This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Fix concurrent VM creation due to busy device error #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkowlzz
requested review from
chanwit,
luxas,
stealthybox and
twelho
as code owners
darkowlzz
force-pushed
the
concurrent-vm-creation
branch
from
ea7460b
to
cd1d2e3
Compare
Add another lock in DeactivateSnapshot(). Move DeactivateSnapshot from pkg/dmlegacy/cleanup to pkg/dmlegacy to avoid cyclic dependency.
darkowlzz
force-pushed
the
concurrent-vm-creation
branch
from
cd1d2e3
to
63cd55c
Compare
|
lgtm pending tests |
|
We were able to create some hard-to-reproduce / transient lock failures on @darkowlzz's DigitalOcean dev machine. I was not able to create any lockfile issues after testing ~100 vm's in small and medium sized concurrent batches on my WSL2 laptop. This seems to be working about as stable as it did before 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add another lock in
DeactivateSnapshot().Move
DeactivateSnapshotfrompkg/dmlegacy/cleanuptopkg/dmlegacytoavoid cyclic dependency.
TODO: Add an e2e test.
Fixes: #711