Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Small test improvements #760

Merged
merged 2 commits into from
Jan 4, 2021
Merged

Small test improvements #760

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2197c21
Mark Run() as helper function
bboreham Dec 23, 2020
68db649
Fix typos
bboreham Dec 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions e2e/util/command.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ const (
)

// Command is an ignite command execution helper. It takes a binary and the
// arguments to run with the binary. It provides a chaining methods to
// fascilitate easy construction of the command.
// arguments to run with the binary. It provides chaining methods to
// facilitate easy construction of the command.
type Command struct {
bin string
T *testing.T
Expand Down Expand Up @@ -72,6 +72,7 @@ func (c *Command) Dir(path string) *Command {
// on encountering an error, call Command.Cmd.CombinedOutput() or the
// appropriate method to execute the command separately.
func (c *Command) Run() {
c.T.Helper()
out, err := c.Cmd.CombinedOutput()
assert.Check(c.T, err, fmt.Sprintf("cmd: \n%q\n%s", c.Cmd, out))
if err != nil {
Expand Down