This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Avoid race between stop/kill and wait #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code adapted from RemoveContainer() which already had this fix.
bboreham
requested review from
chanwit,
darkowlzz,
luxas,
stealthybox and
twelho
as code owners
Now the underlying problem is fixed.
darkowlzz
approved these changes
Jan 18, 2021
|
Very nice patch -- thanks for catching this @bboreham |
stealthybox
added
area/runtime
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on how fast Docker actions the auto-remove on container death, the wait can fail with "No such container".
Code adapted from RemoveContainer() which already had this fix.
Also make clear that such an error comes from waiting for container.
Fixes #679, #658