Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

update cni version to 1.0.1 #903

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

abn
Copy link

@abn abn commented Mar 7, 2022

This builds on top of the work done by @gaby in #863.

Closes: #863

abn and others added 2 commits March 7, 2022 16:06
Co-authored-by: Juan Calderon-Perez <835733+gaby@users.noreply.github.com>
@gaby
Copy link
Contributor

gaby commented Mar 7, 2022

👍🏻 For this, I couldnt get my builds pass for #863

@abn
Copy link
Author

abn commented Mar 7, 2022

@gaby think I got the builds to pass now. I am not sure how to debug the e2e tests as I do not really use ignite. I came here trying to update cni version for containerlabs. Any help would be appreciated.

Also I am unsure what snyk is complaining about as I cannot access the details.

@gaby
Copy link
Contributor

gaby commented Apr 27, 2022

@chanwit @darkowlzz @stealthybox any updates on this?

@darkowlzz
Copy link
Contributor

Hi @abn and @gaby , sorry for the late response. Before we update CNI, we'll have to bring back ignite to a good shape.
I've created #923 to fix the current CI failures.
I also see a lot of dependency updates in this PR that may not be directly related to CNI. I can try updating those dependencies in a separate PR once the builds are in a good shape. Just trying to reduce the change surface to avoid any unintended changes.

Thanks for pushing this forward.

@darkowlzz darkowlzz added the area/networking Issues related to networking label Apr 30, 2022
@darkowlzz
Copy link
Contributor

Hi, I tried updating the unrelated dependencies first and when I updated containerd, it also updates CNI to v1, which also required updating firacracker-go-sdk, as the old version no longer worked with new CNI, and everything else. So at the end, I ended up with everything that's in this PR.
The main branch is in a good state now with all the pipelines passing. It'd be good if you just rebase this and see how the pipeline behaves.

I'd like to know the reason for changing run to create in e2e test e2e/config_test.go in the last commit. I believe we need it to be run for the runtime to be set on the VMs. Create just creates the object on disk. Since the CI is green now, maybe you can try to see what happens without those change?

github.com/stretchr/testify v1.6.1
github.com/vishvananda/netlink v1.1.0
github.com/stretchr/testify v1.7.0
github.com/vishvananda/netlink v1.1.1-0.20220224135417-f7fd7af4377d
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be v1.2.0-beta now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/networking Issues related to networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants