This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Serializer, Storage and Client implementations #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncoding in a unified way.
…. Also, add a Created field to ObjectMeta
…ng/setting/deleting/listing objects and their metadata
luxas
changed the title
|
This is ready to merge 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@twelho this shows how we could abstract away
a) the underlying storage (could provide other forms, e.g. using k8s API, etcd or GitOps),
b) how the filtering/matching works
c) caching for resources only partially loaded from disk
Note that pretty much all of the client is autogenerated based on a template, that is nice 😄
Let's use this ASAP for the ongoing refactor, and rebase the whole program on top of this approach.