Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add external secrets profile with crs kustomization reference #202

Merged
merged 25 commits into from
Dec 15, 2022
Merged

add external secrets profile with crs kustomization reference #202

merged 25 commits into from
Dec 15, 2022

Conversation

waleedhammam
Copy link
Contributor

@waleedhammam waleedhammam commented Dec 4, 2022 •
edited
Loading

Updated

1- Update ESO profile to latest 0.6.1
2- Make it installable with profiles to leaf cluster
3- Add kustomziation ref to secrets CRs paths and editable in values.yaml

Installation to management cluster

managment-profile.mp4

Installation to leaf cluster

leaf-profile.mp4

@waleedhammam waleedhammam marked this pull request as ready for review December 13, 2022 10:16
@enekofb enekofb self-requested a review December 14, 2022 15:23
enekofb
enekofb previously approved these changes Dec 14, 2022
View reviewed changes
Copy link

@enekofb enekofb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with comments, it woudl be cool to address them but we could also iterate over

@waleedhammam waleedhammam requested a review from enekofb December 15, 2022 09:55
serboctor
serboctor previously approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@serboctor serboctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM....just some minor suggestions

charts/external-secrets/README.md Outdated Show resolved Hide resolved
charts/external-secrets/README.md Outdated Show resolved Hide resolved
charts/external-secrets/README.md Outdated Show resolved Hide resolved
@waleedhammam
Apply suggestions from code review
d6788a6 
Co-authored-by: serboctor <sara.boctor@weave.works>
@waleedhammam
Update charts/external-secrets/Bootstrapping-Guide.md
e68b17f 
Co-authored-by: serboctor <sara.boctor@weave.works>
@waleedhammam
Update charts/external-secrets/Bootstrapping-Guide.md
903f201 
Co-authored-by: serboctor <sara.boctor@weave.works>
serboctor
serboctor previously approved these changes Dec 15, 2022
View reviewed changes
enekofb
enekofb approved these changes Dec 15, 2022
View reviewed changes
Copy link

@enekofb enekofb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 thanks for considering the comments

@waleedhammam waleedhammam merged commit 7a45ff2 into main Dec 15, 2022
@waleedhammam waleedhammam deleted the 1929-eso-profile branch December 15, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahsayde ahsayde ahsayde approved these changes

@enekofb enekofb enekofb approved these changes

@serboctor serboctor serboctor left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@waleedhammam @serboctor @enekofb @ahsayde